On Sat, Feb 17, 2007 at 01:28:22PM -0500, Tom Lane wrote: > Magnus Hagander <[EMAIL PROTECTED]> writes: > > I'd also like a comment from at least one other "patch reviewer" that > > the methods used are good. > > It looks reasonable as far as it goes. One thought is that pg_dump > really should have noticed that it was writing a broken archive. > On machines where off_t is 32 bits, can't we detect the overflow > situation?
Tested on MSVC as well, works. Also tested and doesn't break the build on Linux (which shouldn't be affected at all). So, patch applied to HEAD and 8.2. //Magnus ---------------------------(end of broadcast)--------------------------- TIP 4: Have you searched our list archives? http://archives.postgresql.org