> > > > I agree that this code is both wrong and unreadable 
> (although in 
> > > > practice the _setmode will probably never fail, which 
> is why our 
> > > > attention hasn't been drawn to it).  Is someone going 
> to submit a 
> > > > patch?  I'm hesitant to change the code myself since 
> I'm not in a 
> > > > position to test it.
> > > 
> > > I can look at fixing that. Is it something we want to do 
> for 8.2, or 
> > > wait until 8.3? If there's a hidden bug, I guess 8.2?
> > 
> > Magnus, is this the right fix?
> 
> Claudio sent me some small updates to the patch;  updated 
> version attached.

Tested, passes all regression tests on MingW.

//Magnus

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq

Reply via email to