Added to TODO:

        * Add SPI_gettypmod() to return the typemod for a TupleDesc


---------------------------------------------------------------------------

Tom Lane wrote:
> "Pavel Stehule" <[EMAIL PROTECTED]> writes:
> > rettupdesc = lookup_rowtype_tupdesc(rettype,0);
> 
> This is wrong --- if you don't know what typmod to use, *always* pass -1
> not 0.  (I suspect that rettype is RECORD and that -1 would have
> resulted in a NULL result.)
> 
> It seems like SPI is missing a needed function: it should have an
> SPI_gettypmod to go along with SPI_gettypeid.  This would probably
> give you the correct typmod to pass to lookup_rowtype_tupdesc here.
> 
>                       regards, tom lane
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
       choose an index scan if your joining column's datatypes do not
       match

Reply via email to