On Sun, Jul 10, 2005 at 10:00:04AM -0400, Bruce Momjian wrote: > Marko Kreen wrote: > > On Sun, Jul 10, 2005 at 10:59:35AM +0200, Stefan Kaltenbrunner wrote: > > > looks like the latest pgcrypto-patches that just got applied cause > > > widespread failures on the buildfarm machines: > > > > > > http://www.pgbuildfarm.org/cgi-bin/show_status.pl > > > > Seems like Bruce forgot to 'cvs add' new files... > > All new files added, and I think all the pgcrypto patches are now > applied to CVS. I just added the openssl version patch, I see the > IMMUTABLE patch is already in, and I see the autoconfiguration stuff is > already in. > > Is there anything else outstanding for pgcrypto?
I see from buildfarm, that pgcrypto fails to build on a non-OpenSSL machine. The reason for it is a stale openssl/bn.h include in pgp-pubdec.c. I did not spot it, as even for --without-openssl build I still had OpenSSL intalled. -- marko
Index: contrib/pgcrypto/pgp-pubdec.c =================================================================== RCS file: /projects/cvsroot/pgsql/contrib/pgcrypto/pgp-pubdec.c,v retrieving revision 1.1 diff -c -r1.1 pgp-pubdec.c *** contrib/pgcrypto/pgp-pubdec.c 10 Jul 2005 13:46:29 -0000 1.1 --- contrib/pgcrypto/pgp-pubdec.c 10 Jul 2005 15:28:26 -0000 *************** *** 30,37 **** */ #include <postgres.h> - #include <openssl/bn.h> - #include "px.h" #include "mbuf.h" #include "pgp.h" --- 30,35 ----
---------------------------(end of broadcast)--------------------------- TIP 9: In versions below 8.0, the planner will ignore your desire to choose an index scan if your joining column's datatypes do not match