Dear Thomas,

> I'm trying to change the Makefile system for PL/Java so that it uses
> PGXS instead of compiling using a complete PostgreSQL source tree. As it
> turns out, the directory "include/port/win32" is not present in the
> PostgreSQL binary installation. Without it, it's not possible to compile
> on win32.

Please find enclosed a patch which attempts to fix your use of pgxs under
win32:
- install port/* includes
- install libpostgres.a by default (it seems to require MAKE_DLL=true)
- fix include path under win32 portname

The specific win32 fixes are performed in the Makefile.win32 file.

I have no mean to test that on a win32 machine. Could you do it?

I'm wondering whether the MAKE_DLL fix should also be done under cygwin.
Any opinion?

Thanks in advance,

-- 
Fabien Coelho - [EMAIL PROTECTED]
*** ./src/include/Makefile.orig Wed Nov  3 10:32:29 2004
--- ./src/include/Makefile      Sun Nov  7 11:14:52 2004
***************
*** 18,24 ****
  
  # Subdirectories containing headers for server-side dev
  SUBDIRS = access bootstrap catalog commands executor lib libpq mb \
!       nodes optimizer parser port regex rewrite storage tcop utils
  
  # Install all headers
  install: all installdirs remove-old-headers
--- 18,25 ----
  
  # Subdirectories containing headers for server-side dev
  SUBDIRS = access bootstrap catalog commands executor lib libpq mb \
!       nodes optimizer parser port regex rewrite storage tcop utils \
!       port port/win32 port/win32/arpa port/win32/netinet port/win32/sys
  
  # Install all headers
  install: all installdirs remove-old-headers
*** ./src/makefiles/Makefile.win32.orig Thu Oct 28 08:24:17 2004
--- ./src/makefiles/Makefile.win32      Sun Nov  7 10:44:58 2004
***************
*** 35,37 ****
--- 35,48 ----
  ifneq (,$(findstring src/pl/plpython,$(subdir)))
  override CPPFLAGS+= -DUSE_DL_IMPORT
  endif
+ 
+ # special win32 headers are provided here
+ ifdef PGXS
+ override CPPFLAGS+= $(includedir_server)/port/win32
+ endif
+ 
+ # it is better to install shared-libraries anyway?
+ # may be overriden with make MAKE_DLL=false install
+ ifndef MAKE_DLL
+ MAKE_DLL      = true
+ endif
---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
    (send "unregister YourEmailAddressHere" to [EMAIL PROTECTED])

Reply via email to