On Sat, 2004-10-23 at 17:25 -0400, Tom Lane wrote:
> Peter Eisentraut <[EMAIL PROTECTED]> writes:
> > SELECT to_number('485-', '999S');
> > to_number
> > -----------
> > 485
>
> > Is this a bug or intentional?
>
> Tracing through this, it looks like the problem is that NUM_processor()
> has no switch case for NUM_S (nor does the default case raise an error,
> which seems a risky practice to me).
>
> Karel, can you verify this and submit a fix?
Yes, you're right. It strange, but NUM_S missing there. The conversion
from string to number is less stable part of formatting.c...
I have already 2000 lines of code of new generation of to_..()
functions. But all will available in 8.1.
The patch is in the attachment.
Karel
--
Karel Zak
http://home.zf.jcu.cz/~zakkr
--- pgsql/src/backend/utils/adt/formatting.c.num_s 2004-10-25 13:51:58.009789928 +0200
+++ pgsql/src/backend/utils/adt/formatting.c 2004-10-25 15:23:09.315025104 +0200
@@ -3625,7 +3625,7 @@
{
#ifdef DEBUG_TO_FROM_CHAR
- elog(DEBUG_elog_output, " --- scan start --- ");
+ elog(DEBUG_elog_output, " --- scan start --- >>%s<<", Np->number);
#endif
if (*Np->inout_p == ' ')
@@ -3642,7 +3642,7 @@
/*
* read sign
*/
- if (*Np->number == ' ' && (id == NUM_0 || id == NUM_9 || NUM_S))
+ if (*Np->number == ' ' && (id == NUM_0 || id == NUM_9 || id == NUM_S))
{
#ifdef DEBUG_TO_FROM_CHAR
@@ -4138,6 +4138,7 @@
case NUM_0:
case NUM_DEC:
case NUM_D:
+ case NUM_S:
if (Np->type == TO_CHAR)
{
NUM_numpart_to_char(Np, n->key->id);
---------------------------(end of broadcast)---------------------------
TIP 4: Don't 'kill -9' the postmaster
