On Tue, 3 Aug 2004, Jeff Davis wrote: > On Tue, 2004-08-03 at 03:41, Gavin Sherry wrote: > > Attached is a patch fixing this. > > > > One question I do have: > > > > if (target->savepointLevel != s->savepointLevel) > > > > Will this ever be true in the current code? I cannot see anything setting > > savepointLevel explicitly. > > >From reading the lists, it seems like that's allowing for some > functionality that was talked about but wasn't part of the semantics > agreed upon by the end of the discussion.
Yes. Savepoint levels are covered in the spec I was more or less just wondering if there was any more code to come or if I'd missed something. > > I have a question for you also. I just posted a patch at about the same > time you did (I sent it to pgsql-patches, but I haven't seen it appear > yet). Mine was a one-liner (appended to end of this email) and all it > did was add a check into the aforementioned line for a non-null target > pointer. My patch seemed to work, so I'd like to know why you changed > the structure around more. I did notice some things were a little > cleaner, so was it just clean-up or does my patch fail in some way? Just a clean up. Gavin ---------------------------(end of broadcast)--------------------------- TIP 1: subscribe and unsubscribe commands go to [EMAIL PROTECTED]
