Bruce Momjian <[EMAIL PROTECTED]> writes:
but my BSD/OS manual only documents 'cp -R' and mentions:
I think we should switch to -R in our code.
And break the code on who knows how many other systems? No thanks.
If we want to do anything at all with this code, we should eliminate the use of system("cp") entirely in favor of doing the recursive copy logic ourselves. We already have the beginnings of same in the Windows port, and I think we'll be forced down that path anyway for tablespaces.
That seems cleaner to me.
IIRC we don't copy anything but plain files and directories - no special files, symlinks or fifos, so the -R/-r differences shouldn't affect us anyway, should they? Also, that should make the implementation of an internal recursive copy much simpler - far fewer cases to consider.
cheers
andrew
---------------------------(end of broadcast)--------------------------- TIP 6: Have you searched our list archives?
http://archives.postgresql.org
