On Sun, 23 Nov 2003, Tom Lane wrote:

> Actually I'd suggest text[], as there is no good reason to pad the
> array entries to a fixed length.

I've implemented this part now and it stores the paremeter names in the 
pg_proc table as a text[] field.

However, in the parser I use IDENT to get the parameter names and already
in the lexer the IDENT tokens are truncated to length NAMEDATALEN.

So I've got 3 options:

 1) Leave it as is now where the system table allows any length
    but the parser only lets you insert "short" identifiers.

 2) Change the type to name[]

 3) Change the parser to accept identifiers of any length and add
    the length check in a later phase for the identifiers that need
    to be shorter.

Any opinions or should I just make a choice myself?

-- 
/Dennis


---------------------------(end of broadcast)---------------------------
TIP 8: explain analyze is your friend

Reply via email to