On Fri, Oct 6, 2017 at 8:45 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Oct 6, 2017 at 8:40 AM, Ashutosh Bapat > <ashutosh.ba...@enterprisedb.com> wrote: >> Sorry. I sent a wrong file. Here's the real v37. > > Committed 0001-0006. I made some assorted comment and formatting > changes and two small substantive changes: > > - In try_nestloop_path, bms_free(outerrelids) before returning if we > can't reparameterize.
Hmm. I missed that. > > - Moved the call to try_partition_wise_join inside > populate_joinrel_with_paths, instead of always calling it just after > that function is called. This looks good too. > > I think this is very good work and I'm excited about the feature. Thanks a lot Robert for detailed review and guidance. Thanks a lot Rafia for benchmarking the feature with TPCH and esp. very large scale database and also for testing and reported some real issues. Thanks Rajkumar for testing it with an exhaustive testset. Thanks Amit Langote, Thomas Munro, Dilip Kumar, Antonin Houska, Alvaro Herrera and Amit Khandekar for their review comments and suggestions. Thanks Jeevan Chalke, who used the patchset to implement partition-wise aggregates and provided some insights offlist. Sorry if I have missed anybody. As Robert says in the commit message, there's more to do but now that we have basic feature, improving it incrementally becomes a lot easier. -- Best Wishes, Ashutosh Bapat EnterpriseDB Corporation The Postgres Database Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
