On Thu, Oct 5, 2017 at 4:12 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Oct 4, 2017 at 10:11 AM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Wed, Oct 4, 2017 at 11:04 PM, Robert Haas <robertmh...@gmail.com> wrote: >>> Not really; dynahash won't merge two keys just because their hash >>> codes come out the same. But you're right; that's probably not the >>> best way to do it. TBH, why do we even have pgss_hash_fn? It seems >>> like using tag_hash would be superior. >> >> Yes, using tag_hash would be just better than any custom formula. > > OK, here's v4, which does it that way.
v4 looks correct to me. Testing it through (pgbench and some custom queries) I have not spotted issues. If the final decision is to use 64-bit query IDs, then this patch could be pushed. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
