On Sat, Sep 16, 2017 at 2:15 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > Yes, we can do that and that is what I think is probably better. So, > the question remains that in which case non-parallel-aware partial > append will be required? Basically, it is not clear to me why after > having parallel-aware partial append we need non-parallel-aware > version? Are you keeping it for the sake of backward-compatibility or > something like for cases if someone has disabled parallel append with > the help of new guc in this patch?
We can't use parallel append if there are pathkeys, because parallel append will disturb the output ordering. Right now, that never happens anyway, but that will change when https://commitfest.postgresql.org/14/1093/ is committed. Parallel append is also not safe for a parameterized path, and set_append_rel_pathlist() already creates those. I guess it could be safe if the parameter is passed down from above the Gather, if we allowed that, but it's sure not safe in a case like this: Gather -> Nested Loop -> Parallel Seq Scan -> Append -> whatever If it's not clear why that's a disaster, please ask for a more detailed explaination... -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
