On 9/20/17 13:13, Dagfinn Ilmari Mannsåker wrote: > I have no opinion on the bulk of this patch set, but skimming it out of > curiosity I noticed that the plperl change seems to have lost the > dependency on plperl_helpers.h from the xsubpp targets:
Those commands don't actually require plperl_helpers.h, do they? >> diff --git a/src/pl/plperl/GNUmakefile b/src/pl/plperl/GNUmakefile >> index 191f74067a..66a2c3d4c9 100644 >> --- a/src/pl/plperl/GNUmakefile >> +++ b/src/pl/plperl/GNUmakefile >> @@ -81,13 +81,9 @@ perlchunks.h: $(PERLCHUNKS) >> >> all: all-lib >> >> -SPI.c: SPI.xs plperl_helpers.h >> +%.c: %.xs >> @if [ x"$(perl_privlibexp)" = x"" ]; then echo "configure switch >> --with-perl was not specified."; exit 1; fi >> - $(PERL) $(XSUBPPDIR)/ExtUtils/xsubpp -typemap >> $(perl_privlibexp)/ExtUtils/typemap $< >$@ >> - >> -Util.c: Util.xs plperl_helpers.h >> - @if [ x"$(perl_privlibexp)" = x"" ]; then echo "configure switch >> --with-perl was not specified."; exit 1; fi >> - $(PERL) $(XSUBPPDIR)/ExtUtils/xsubpp -typemap >> $(perl_privlibexp)/ExtUtils/typemap $< >$@ >> + $(PERL) $(XSUBPPDIR)/ExtUtils/xsubpp -typemap >> $(perl_privlibexp)/ExtUtils/typemap -output $@ $< -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
