On Tue, Sep 19, 2017 at 9:49 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Aug 24, 2017 at 11:26 AM, Jesper Pedersen > <jesper.peder...@redhat.com> wrote: >> Based on the feedback in this thread, I have moved the patch to "Ready for >> Committer". > > Reviewing 0001: > > _hash_readpage gets the page LSN to see if we can apply LP_DEAD hints, > but if the table is unlogged or temporary, the LSN will never change, > so the test in _hash_kill_items will always think that it's OK to > apply the hints. (This seems like it might be a pretty serious > problem, because I'm not sure what would be a viable workaround.) >
This point has been discussed above [1] and to avoid this problem we are keeping the scan always behind vacuum for unlogged and temporary tables as we are doing without this patch. That will ensure vacuum won't be able to remove the TIDs which we are going to mark as dead. This has been taken care in patch 0003. I understand that this is slightly ugly, but the other alternative (as mentioned in the email [1]) is much worse. [1] - https://www.postgresql.org/message-id/CAA4eK1J6xiJUOidBaOt0iPsAdS0%2Bp5PoKFf1R2yVjTwrY_4snA%40mail.gmail.com -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
