On 9/17/17 18:21, Rosser Schwarz wrote: > On Fri, Sep 1, 2017 at 10:22 AM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com > <mailto:peter.eisentr...@2ndquadrant.com>> wrote: >> I understand the --drop-slot part. But I don't understand what it means >> to ignore a missing replication slot when running --start. > > I'm not sure I do either, honestly. I followed the Principle of Least > Surprise in making it a no-op when those switches are used and the slot > doesn't exist, over "no one will ever do that". Because someone will. > > I'm happy to hear suggestions on what to do in that case beyond exit > cleanly.
Nonsensical option combinations should result in an error. It appears that you have removed the interaction of --start and --if-exists in your last patch, but the documentation patch still mentions it. Which is correct? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
