On Fri, Sep 8, 2017 at 3:13 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Sep 8, 2017 at 1:17 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: >> You are right. I have changed the ordering and passed OuterUserId via >> FixedParallelState. > > This looks a little strange: > > + SetCurrentRoleId(fps->outer_user_id, fps->is_current_user_superuser); > > The first argument says "outer" but the second says "current". I'm > wondering if we can just make the second one is_superuser. >
No issues changed as per suggestion. > I'm also wondering if, rather than using GetConfigOptionByName, we > should just make the GUC underlying is_superuser non-static and use > the value directly. If not, then I'm alternatively wondering whether > we should maybe use a less-generic name than varval. > I think we can go either way. So prepared patches with both approaches. In fix_role_handling_parallel_worker_v3_1.patch, I have changed the variable name and in fix_role_handling_parallel_worker_v3_2.patch, I have exposed the guc is_superuser. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
fix_role_handling_parallel_worker_v3_1.patch
Description: Binary data
fix_role_handling_parallel_worker_v3_2.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
