On Mon, Jul 31, 2017 at 5:42 PM, Amit Langote <langote_amit...@lab.ntt.co.jp > wrote:
> > On a second thought though, I think we should list the foreign table > partitions' limitations in only one place, that is, the CREATE FOREIGN > TABLE reference page. Listing them under 5.10.2.3. seems a bit off to me, > because other limitations listed there are those of the new partitioned > table objects, such as lack of global index constraints, etc. Lack of > tuple-routing to foreign partitions does not seem to me of the similar > nature. Also, the same text is no longer repeated in 3 different places. > > Thoughts on the updated patch? > Overall, works for me. grammar (add a couple of commas for flow) and style (dropping the first "the") current: "(both the user-defined constraints such as <literal>CHECK</> or <literal>NOT NULL</> clauses and the partition constraint)" proposed: "(both user-defined constraints, such as <literal>CHECK</> or <literal>NOT NULL</> clauses, and the partition constraint)" Thanks! David J.
