Hi, On 2017-07-29 16:14:08 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > [ 0002-Move-ExecProcNode-from-dispatch-to-function-pointer-.patch ] > > Here's a reviewed version of this patch.
Thanks! I pushed both now. > I added dummy ExecProcNodeMtd functions to the various node types that > lacked them because they expect to be called through MultiExecProcNode > instead. In the old coding, trying to call ExecProcNode on one of those > node types would have led to a useful error message; as you had it, > it'd have dumped core, which is not an improvement. Ok, makes sense. > Also, I removed the ExecReScan stanza from ExecProcNodeFirst; that > should surely be redundant, because we should only get to that function > through ExecProcNode(). If somehow it's not redundant, please add a > comment explaining why not. Makes sense too. > Some other minor cosmetic changes, mostly comment wordsmithing. Thanks! Julien, could you quickly verify that everything's good for you now too? Regards, Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
