On Sat, Jul 29, 2017 at 12:05 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Ashutosh Sharma <ashu.coe...@gmail.com> writes: >> On Fri, Jul 28, 2017 at 10:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Uh-huh. So the issue is indeed that they're injecting PERL_IMPLICIT_SYS >>> via a command-line #define rather than putting it into perl's config.h, >>> and that results in a change in the apparent size of the PerlInterp >>> struct (because of IMem and friends). > >> Yes, That's right. We would have seen different result if the >> PERL_IMPLICIT_SYS would not have been defined globally. > > I've pushed the changes to the build scripts now. I had to revise the > Mkvcbuild.pm part a bit, because you'd forgotten to propagate the extra > defines into hstore_plperl.
Thanks for that. So that code is untested; please confirm > that HEAD works in your problem environment now. > I quickly ran the some basic test-cases on my Windows machine (machine where i have been regenerating the issue) and they are all passing. Also, all the automated test-cases for contrib module hstore_plperl are passing. > I notice that Mkvcbuild.pm is artificially injecting a define for > PLPERL_HAVE_UID_GID. I strongly suspect that that was a hack meant > to work around the lack of this mechanism, and that we could now > get rid of it or clean it up. But there's no evidence in the commit > log about the reason for it --- it seems to go back to the original > addition of MSVC support. Anybody remember? > > regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
