On 2017-06-16 13:44:30 -0400, Bruce Momjian wrote: > On Fri, Jun 16, 2017 at 01:34:01PM -0400, Tom Lane wrote: > > > I could live with both of these proposed > > > changes, the selection of the changes you posted looks like it could be > > > improved by code changes, but that's obviously a large amount of work. > > > > In the end, the only thing that fixes this sort of stuff is to be more > > rigid about making the code fit into 80 columns to begin with. I get > > the impression though that a lot of people work in editor windows that > > are wider than that, so the code looks fine to them when it slops over > > a bit. > > Yes, it is all about <80 column output. The current pgindent does > everything possible to accomplish that --- the question is whether we > want uglier code to do it.
For me personally the misindentation is way uglier than a too long line. I think a number of those long-lines are there because pgindent sometimes re-indents lines that are continuations of previous ones pretty far, making it hard to reduce indentation. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers