On 2017/06/15 4:51, Robert Haas wrote: > On Wed, Jun 14, 2017 at 8:02 AM, Jeevan Ladhe > <jeevan.la...@enterprisedb.com> wrote: >> Here are the details of the patches in attached zip. >> 0001. refactoring existing ATExecAttachPartition code so that it can be >> used for >> default partitioning as well >> 0002. support for default partition with the restriction of preventing >> addition >> of any new partition after default partition. >> 0003. extend default partitioning support to allow addition of new >> partitions. >> 0004. extend default partitioning validation code to reuse the refactored >> code >> in patch 0001. > > I think the core ideas of this patch are pretty solid now. It's come > a long way in the last month.
+1 BTW, I noticed the following in 0002: @@ -1322,15 +1357,59 @@ get_qual_for_list(PartitionKey key, PartitionBoundSpec *spec) [ ... ] + oldcxt = MemoryContextSwitchTo(CacheMemoryContext); I'm not sure if we need to do that. Can you explain? Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
