On Thu, Jun 1, 2017 at 8:24 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, May 31, 2017 at 1:18 PM, Dilip Kumar <dilipbal...@gmail.com> wrote: >> + if (jointype = JOIN_SEMI) >> + { >> + sjinfo->jointype = JOIN_INNER; >> + } > > That is pretty obviously half-baked and completely untested.
Actually, I was not proposing this patch instead I wanted to discuss the approach. I was claiming that for non-equal JOIN_SEMI selectivity estimation instead of calculating selectivity in an existing way i.e = 1- (selectivity of equal JOIN_SEMI) the better way would be = 1- (selectivity of equal). I have only tested only standalone scenario where it solves the problem but not the TPCH cases. But I was more interested in discussing that the way I am thinking how it should calculate the nonequal SEMI join selectivity make any sense. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers