On Fri, Apr 7, 2017 at 12:38 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Apr 4, 2017 at 9:42 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Wed, Apr 5, 2017 at 2:54 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> (I'm personally not that much in love with PG_USED_FOR_ASSERTS_ONLY, >>> because it tends to confuse pgindent.) >> >> I would be incline to just do that, any other solution I can think of >> is uglier than that. > > Actually, no. Looking at this issue again the warning is triggered > because the Assert() clause is present in USE_ASSERT_CHECKING. So > instead of removing PG_USED_FOR_ASSERTS_ONLY, here is a more simple > patch that fixes the problem. No need to put the variable *rte within > ifdefs as well.
Bah. This actually fixes nothing. Attached is a different patch that really addresses the problem, by removing the variable because we don't want planner_rt_fetch() to run for non-Assert builds. -- Michael
costsize-warning-fix-3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
