On Fri, Mar 31, 2017 at 10:10 AM, Aleksander Alekseev <a.aleks...@postgrespro.ru> wrote: > Turned out that there is an unused argument `isroot` in > `btree_xlog_split` procedure. Suggested patch fixes it. > > This issue was discovered by Anastasia Lubennikova, coding is done by me.
Hmm. I don't see anything wrong with that, particularly, but it seems we also don't need the distinction between XLOG_BTREE_SPLIT_L and XLOG_BTREE_SPLIT_L_ROOT or likewise between XLOG_BTREE_SPLIT_R and XLOG_BTREE_SPLIT_R_ROOT -- in which case I think this patch should go a little further and do all of that together. It looks like this is fallout from Heikki's 2014 commit 40dae7ec537c5619fc93ad602c62f37be786d161, which removed log_incomplete_split(). -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
