On Fri, Mar 31, 2017 at 1:50 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Kevin Grittner <kgri...@gmail.com> writes: >> On Thu, Mar 23, 2017 at 7:14 PM, Thomas Munro >> <thomas.mu...@enterprisedb.com> wrote: >>> my only other comment would be a bikeshed issue: >>> Enr isn't a great name for a struct. > >> I know, but EphemeralNamedRelation starts to get kinda long, >> especially when making the normal sorts of concatenations. I >> started making the change and balked when I saw things like >> EphemeralNamedRelationMetadataData and a function named >> EphemeralNamedRelationMetadataGetTupDesc() in place of >> EnrmdGetTupDesc(). A 40 character function name make for a lot of >> line-wrapping to stay within pgindent limits. Any suggestions? > > I would vote for calling the struct typedef EphemeralNamedRelation and > using the abbreviation ENR (capitalized that way, not as Enr) in related > function names, where that seemed sensible. I really do *not* like > "Enr" as a global name.
Yeah, I had the same thought about capitalization but wasn't sure if it was worth suggesting. But since Tom did, +1 from me. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
