On 27 March 2017 at 15:26, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Sat, Mar 25, 2017 at 9:50 PM, Craig Ringer <cr...@2ndquadrant.com> wrote: >> I'm fairly confident that I overlooked single row mode entirely in the >> original patch, though it's long enough ago that it's hard for me to >> remember exactly. >> >> I don't really have much of an opinion on the best handling of it. >> >> I would expect to be setting single-row mode just before I requested >> the *result* from the next pending query, since it relates to result >> processing rather than query dispatch. But that's about all the >> opinion I have here. > > Yeah, I think that it makes sense to allow users to switch to single > row mode before requesting a result in the queue. It seems to me that > this should also be effective only during the fetching of one single > result set. When the client moves on to the next item in the queue we > should make necessary again a call to PQsetSingleRowMode(). > > Regarding the patch, I have spotted the following things in the last version: > - src/test/modules/Makefile should include test_libpq. > - Regression tests from 0002 are failing: > ok 1 - testlibpqbatch disallowed_in_batch > ok 2 - testlibpqbatch simple_batch > ok 3 - testlibpqbatch multi_batch > ok 4 - testlibpqbatch batch_abort > ok 5 - testlibpqbatch timings > not ok 6 - testlibpqbatch copyfailure
There are only a few more days left of this commit fest. Things are sounding pretty ready here, with some final cleanups pending. It'd be cool to get this into Pg 10 :) -- Craig Ringer http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
