Off-list by accident. Re-adding the list. On Tue, Mar 21, 2017 at 10:37 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Mar 21, 2017 at 9:49 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Tue, Mar 21, 2017 at 5:05 AM, Amit Langote >> <langote_amit...@lab.ntt.co.jp> wrote: >>> Attached updated patches. >> >> Committed 0001 after removing a comma. > > Regarding 0002, I notice this surprising behavior: > > rhaas=# create table foo (a int, b text) partition by list (a); > CREATE TABLE > rhaas=# select relfilenode from pg_class where oid = 'foo'::regclass; > relfilenode > ------------- > 16385 > (1 row) > > Why do we end up with a relfilenode if there's no storage? I would > have expected to see 0 there. > > Other than that, there's not much to see here. I'm a little worried > that you might have missed some case that can result in an access to > the file, but I can't find one. Stuff I tried: > > VACUUM > VACUUM FULL > CLUSTER > ANALYZE > CREATE INDEX > ALTER TABLE .. ALTER COLUMN .. TYPE > TRUNCATE > > It would be good to go through and make sure all of those - and any > others you can think of - are represented in the regression tests. > > Also, a documentation update is probably in order to explain that > we're not going to accept heap_reloptions on the parent because the > parent has no storage; such options must be set on the child in order > to have effect. > > -- > Robert Haas > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company
-- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
