On 22/03/17 13:36, Peter Eisentraut wrote: > On 3/20/17 16:08, Peter Eisentraut wrote: >> The current patch causes a failure in the pg_dump tests, because the >> generated CREATE SUBSCRIPTION commands make connection attempts that >> don't work. We have the pg_dump option --no-create-subscription-slots >> for this, but I suppose we should expand that to >> --no-subscription-connect and use the new NOCONNECT option instead. > > Small top-up patch to accomplish that. >
Works for me. I'd maybe explicitly mention in the docs for ---no-subscription-connect that it dumps subscriptions as CREATE SUBSCRIPTION ... WITH(NOCONNECT). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
