Re: [HACKERS] ANALYZE command progress checker

[vinayak]

On 2017/03/21 21:25, Haribabu Kommi wrote:

On Tue, Mar 21, 2017 at 3:41 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp <mailto:pokale_vinayak...@lab.ntt.co.jp>> wrote:

    Thank you for testing the patch on Windows platform.


Thanks for the updated patch.


the PROGRESS_ANALYZE_NUM_ROWS_SAMPLED produces wrong results.

It works good for a normal relation. But for a relation that contains child tables,

Thank you for reviewing the patch.

The attached patch implements a way to report sample rows count from acquire_sample_rows() even if called for child tables.

How about adding another phase called PROGRESS_ANALYZE_PHASE_COLLECT_INHERIT_SAMPLE_ROWS and set this phase only when it is an inheritance analyze operation. And adding

some explanation of ROWS_SAMPLED phase about inheritance tables

relation that contains child relations also.

how these sampled rows are calculated will provide good analyze progress of

I have added the phase called PROGRESS_ANALYZE_PHASE_COLLECT_INH_SAMPLE_ROWS.

I have also updated the documentation.


Comment?

Regards,
Vinayak Pokale
NTT Open Source Software Center

The ANALYZE command takes long time in computing statistics phase.So I think we can add some column or phase so that user can easily understand the progress. How about adding new column like "num_rows_processed" will compute the statistics of specified column? How about separate the computing "inheritance statistics" phase from the computing regular "single table" statistics.

pg_stat_progress_analyze_v5.patch
Description: binary/octet-stream

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers