Amit, Michael, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > On 2017/03/09 11:51, Michael Paquier wrote: > > On Wed, Mar 8, 2017 at 5:10 PM, Amit Langote > > <langote_amit...@lab.ntt.co.jp> wrote: > >> On 2017/03/08 16:47, Michael Paquier wrote: > >>> Only regular tables are tested as valid objects. Testing toast tables > >>> is not worth the complication. Could you add as well a matview? > >> > >> Done in the attached updated patch. > > > > +select count(*) > 0 from pg_visibility('matview'); > > + ?column? > > +---------- > > + f > > +(1 row) > > That's quite a generic name :) You may want to use less common names > > in your tests. > > I agree. Updated patch attached. > > > OK, I am marking that as ready for committer.
I'm starting to look over this, seems pretty straight-forward. Barring issues, I should get it committed in probably an hour or two. Thanks! Stephen
signature.asc
Description: Digital signature