On Sat, Mar 4, 2017 at 12:52 AM, Robert Haas <robertmh...@gmail.com> wrote:
> On Thu, Mar 2, 2017 at 3:28 AM, Rader, David <dav...@openscg.com> wrote:
> > Attached is a doc patch that updates the documentation for postgres-fdw
> to
> > include the actual values for the 4 session variables that are set. Does
> > that make sense to clarify?
>
> From my point of view, this would be a sensible thing to document,
> although I feel like the grammar is not quite right, because after
> "establishes remote session settings for the parameters" my brain
> expects a list of parameters rather than a list of parameters and the
> corresponding values. I think it reads better if you change "for the
> parameters" to "for various parameters".
>
> </nitpicking>
>
Revised doc patch attached with various parameters.
From 7bf12d7ed4e38b9c3d37ce2b2f786480f8fd764f Mon Sep 17 00:00:00 2001
From: David Rader <dav...@openscg.com>
Date: Mon, 6 Mar 2017 09:38:52 -0500
Subject: [PATCH] Document postgres-fdw session settings for parameters
---
doc/src/sgml/postgres-fdw.sgml | 31 ++++++++++++++++++++++++++-----
1 file changed, 26 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/postgres-fdw.sgml b/doc/src/sgml/postgres-fdw.sgml
index b31f373..7a9b655 100644
--- a/doc/src/sgml/postgres-fdw.sgml
+++ b/doc/src/sgml/postgres-fdw.sgml
@@ -532,11 +532,32 @@
<para>
<filename>postgres_fdw</> likewise establishes remote session settings
- for the parameters <xref linkend="guc-timezone">,
- <xref linkend="guc-datestyle">, <xref linkend="guc-intervalstyle">,
- and <xref linkend="guc-extra-float-digits">. These are less likely
- to be problematic than <varname>search_path</>, but can be handled
- with function <literal>SET</> options if the need arises.
+ for various parameters:
+ <itemizedlist spacing="compact">
+ <listitem>
+ <para>
+ <xref linkend="guc-timezone"> is set to <literal>UTC</>
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <xref linkend="guc-datestyle"> is set to <literal>ISO</>
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <xref linkend="guc-intervalstyle"> is set to <literal>postgres</>
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <xref linkend="guc-extra-float-digits"> is set to <literal>3</> for remote
+ servers 9.0 and newer and is set to <literal>2</> for older versions
+ </para>
+ </listitem>
+ </itemizedlist>
+ These are less likely to be problematic than <varname>search_path</>, but
+ can be handled with function <literal>SET</> options if the need arises.
</para>
<para>
--
2.5.0
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
