Hello, At Fri, 3 Mar 2017 12:53:04 +0900, Michael Paquier <michael.paqu...@gmail.com> wrote in <cab7npqsqalozfng+5tf9s1tzs2pce-ghhnmg31qnsusv9vm...@mail.gmail.com> > On Thu, Mar 2, 2017 at 2:20 PM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: > > 5) Just remove plain map files and all related code. Addition to > > that, Makefile stores hash digest of authority files in > > Unicode/authoriy_hashes.txt or something that is managed by > > git. > > That may be an idea to check for differences across upstream versions. > But that sounds like a separate discussion to me.
Fine with me either. > > This digest may differ among platforms (typically from cr/nl > > difference) but we can assume *nix for the usage. > > > > I will send the next version after this discussion is settled. > > Sure. There is not much point to move on without Heikki's opinion at > least, or anybody else like Ishii-san or Tom who are familiar with > this code. I would think that Heikki would be the committer to pick up > this change though. So, this is the latest version of this patch in the shape of the option 1. | need some extra opinions is what to do with the old maps: | 1) Just remove them, replacing the old maps by the new radix tree maps. | 2) Keep them around in the backend code, even if they are useless. | 3) Use a GUC to be able to switch from one to the other, giving a | fallback method in case of emergency. | 4) Use an extension module to store the old maps with as well the | previous build code, so as sanity checks can still be performed on the | new maps. regards, -- Kyotaro Horiguchi NTT Open Source Software Center
0001-Use-radix-tree-for-character-conversion_20170306.patch.gz
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
