On 3/3/17 14:51, Petr Jelinek wrote: > On 03/03/17 20:37, Peter Eisentraut wrote: >> On 2/27/17 00:23, Kyotaro HORIGUCHI wrote: >>> Yeah, the patch sends converted string with the length of the >>> orignal length. Usually encoding conversion changes the length of >>> a string. I doubt that the reverse case was working correctly. >> >> I think we shouldn't send the length value at all. This might have been >> a leftover from an earlier version of the patch. >> >> See attached patch that removes the length value. >> > > Well the length is necessary to be able to add binary format support in > future so it's definitely not an omission.
Right. So it appears the right function to use here is pq_sendcountedtext(). However, this sends the strings without null termination, so we'd have to do extra processing on the receiving end. Or we could add an option to pq_sendcountedtext() to make it do what we want. I'd rather stick to standard pqformat.c functions for handling the protocol. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
