On 03/01/2017 05:29 AM, Andres Freund wrote:
On 2017-02-28 20:18:35 -0800, Andres Freund wrote:- Andres, hoping the buildfarm turns greenerOh well, that didn't work. Investigating.
Attaches is the last part of the patch series, rebased to current master and adopting the new chunk header approach. Unlike Slab, this context needs the whole AllocSet header (size, requested_size), and also the block pointer, so no padding seems to be needed.
I've tested this on x86-64 and amrv7l, and the test_decoding test suite passes on both.
FWIW, I'm still not entirely happy with the name "Generation". I agree with Andres that it's perhaps a bit too generic, but more importantly the name might actually be a bit obsolete. There used to be generations of chunks, but that's gone. Now it simply does not reuse the chunks at all, and frees the blocks when they get empty.
It's not entirely FIFO though, because the transactions interleave, so later blocks may be released first. But the "allocated close, freed close" is still there. So perhaps something like "TemporalSet" or something like that would be a better name?
Man, naming things is hard ... regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
gen-context.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
