On 2/16/17 01:13, Peter Geoghegan wrote: > On Wed, Feb 15, 2017 at 9:17 PM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> I have changed it to use ucol_nextSortKeyPart() when appropriate. > > I think it would be fine if the second last argument was > "sizeof(Datum)", not "Min(sizeof(Datum), sss->buflen2)" here:
I don't see anything that guarantees that the buffer length is always at least sizeof(Datum). -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers