On Wed, Feb 1, 2017 at 4:35 PM, Craig Ringer <cr...@2ndquadrant.com> wrote: > Right. Per my comments uothread I don't see why we need to add anything more > to WAL here. > > Stas was concerned about what happens in logical decoding if we crash > between PREPSRE TRANSACTION and COMMIT PREPARED. But we'll always go back > and decode the whole txn again anyway so it doesn't matter. > > We can just track it on ReorderBufferTxn when we see it at PREPARE > TRANSACTION time.
Oh, hmm. I guess if that's how it works then we don't need it in WAL after all. I'm not sure that re-decoding the already-prepared transaction is a very good plan, but if that's what we're doing anyway this patch probably shouldn't change it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
