Peter Eisentraut wrote: > On 12/29/16 4:28 AM, Craig Ringer wrote: > > On 29 December 2016 at 16:51, Craig Ringer <cr...@2ndquadrant.com> wrote: > >> On 28 December 2016 at 22:16, Petr Jelinek <petr.jeli...@2ndquadrant.com> > >> wrote: > >> > >>> About the patch, it looks good to me for master with the minor exception > >>> that: > >>>> + appendStringInfo(buf, "pageno %d, xid %u", > >>>> + trunc.pageno, trunc.oldestXid); > >>> > >>> This should probably say oldestXid instead of xid in the text description. > >> > >> Agreed. > > > > Slightly amended attached. > > I've looked over this. It looks correct to me in principle.
Thanks, pushed. I added a comment in vacuum.c, as well as removing the memcpy()s of the xlog record, which were unnecessary now that there's an intermediate struct. WAL version bumped. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
