On Mon, Dec 5, 2016 at 8:01 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > Moved to next CF with "needs review" status.
I have started reviewing the patch, Some initial comments. $ git apply ../pg_stat_sql_row_mode_2.patch error: patch failed: src/include/catalog/pg_proc.h:2893 error: src/include/catalog/pg_proc.h: patch does not apply Patch is not applying on the head, I think it needs to be rebased. +void +pgstat_count_sqlstmt(const char *commandTag) +{ + PgStat_SqlstmtEntry *htabent; + bool found; + + if (!pgstat_track_sql) + return Callers of pgstat_count_sqlstmt are always ensuring that pgstat_track_sql is true, seems it's redundant here. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers