0005-Add-separate-synchronous-commit-control-for-logical--v16.patch.gz This looks a little bit hackish. I'm not sure how this would behave properly when either synchronous_commit or logical_replication_synchronous_commit is changed at run time with a reload.
I'm thinking maybe this and perhaps some other WAL receiver settings should be properties of a subscription, like ALTER SUBSCRIPTION ... SET/RESET. Actually, maybe I'm a bit confused what this is supposed to achieve. synchronous_commit has both a local and a remote meaning. What behavior are the various combinations of physical and logical replication supposed to accomplish? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
