On Tue, Dec 6, 2016 at 1:54 PM, Fujii Masao <masao.fu...@gmail.com> wrote:
> + <literal>backup</>: The WAL sender is sending a backup.
>
> Seems it's better to use "This WAL sender" rather than "The WAL sender"
> like the descriptions of other fields.
>
> There are two descriptions of "streaming" value. You need to remove
> either of them.
>
> + <literal>streaming</>: The WAL sender is catching up with the
> + primary.
>
> "walsender is catching up with the primary" sounds a bit strange to me.
> What about "This WAL sender's connected standby server is catching up
> with the primary"?
>
> + <literal>streaming</>: The WAL sender has caught up with the
> + primary and is streaming changes.
>
> Same as above.
Agreed with all that. Attached is an updated version.
--
Michael
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 02dab879d9..bf30a9ee08 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -1357,7 +1357,33 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
<row>
<entry><structfield>state</></entry>
<entry><type>text</></entry>
- <entry>Current WAL sender state</entry>
+ <entry>Current WAL sender state.
+ Possible values are:
+ <itemizedlist>
+ <listitem>
+ <para>
+ <literal>backup</>: This WAL sender is sending a backup.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>catchup</>: This WAL sender's connected standby is
+ catching up with the primary.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>startup</>: This WAL sender is starting.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>streaming</>: This WAL sender's connected standby
+ server has caught up with the primary and is streaming changes.
+ </para>
+ </listitem>
+ </itemizedlist>
+ </entry>
</row>
<row>
<entry><structfield>sent_location</></entry>
@@ -1391,7 +1417,27 @@ SELECT pid, wait_event_type, wait_event FROM pg_stat_activity WHERE wait_event i
<row>
<entry><structfield>sync_state</></entry>
<entry><type>text</></entry>
- <entry>Synchronous state of this standby server</entry>
+ <entry>Synchronous state of this standby server.
+ Possible values are:
+ <itemizedlist>
+ <listitem>
+ <para>
+ <literal>async</>: Standby server is asynchronous.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>potential</>: Standby server can potentially become
+ synchronous.
+ </para>
+ </listitem>
+ <listitem>
+ <para>
+ <literal>sync</>: Standby server is synchronous.
+ </para>
+ </listitem>
+ </itemizedlist>
+ </entry>
</row>
</tbody>
</tgroup>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
