On Wed, Nov 30, 2016 at 2:56 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Nov 29, 2016 at 08:45:13PM +0100, Christian Ullrich wrote: >> * Michael Paquier wrote: >> >> > On Wed, Nov 16, 2016 at 12:45 PM, Christian Ullrich >> > <ch...@chrullrich.net> wrote: >> >> I also did a debug build with 1+2+4 that came in at 84 μs/iteration. >> > >> > Moved to next CF. Christian, perhaps this patch should have an extra >> > round of reviews? >> >> It is significantly different from the last version, so yes, of course. > > Patches 0001 (Cosmetic fixes), 0002 (Remove unnecessary CloseHandle) > and 0003 (support for debug CRTs) look in good shape to me. 0004 (Fix > load race) is 0002 from the previous set, and this change makes sense > in itself.
0001 looks fine insofar as it makes things consistent regarding 0 vs. NULL, but the whitespace changes will be reverted by pgindent. (I just tested.) -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
