On Fri, Nov 25, 2016 at 4:32 AM, Dilip Kumar <dilipbal...@gmail.com> wrote: > I have one more question, > > In V1 we were calling dsa_detach in ExecParallelCleanup and in > ParallelQueryMain, but it's removed in v2. > > Any specific reason ? > Does this need to be used differently ? > > ExecParallelCleanup(ParallelExecutorInfo *pei) > { > + if (pei->area != NULL) > + { > + dsa_detach(pei->area); > + pei->area = NULL; > + } > > After this changes, I am getting DSM segment leak warning.
Thanks! I had some chicken-vs-egg problems dealing with cleanup of DSM segments belonging to DSA areas created inside DSM segments. Here's a new version to apply on top of dsa-v7.patch. -- Thomas Munro http://www.enterprisedb.com
dsa-area-for-executor-v3.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers