On 21 November 2016 at 12:23, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello,
>
> At Mon, 21 Nov 2016 11:58:34 +0800, Craig Ringer <cr...@2ndquadrant.com> 
> wrote in <CAMsr+YHdiEMRB+2yBz=xaxbx5qteb73nn1qs5dy4budt_w3...@mail.gmail.com>
>> On 18 November 2016 at 08:15, Craig Ringer <cr...@2ndquadrant.com> wrote:
>> > On 18 November 2016 at 07:10, Michael Paquier <michael.paqu...@gmail.com> 
>> > wrote:
>> >> On Thu, Nov 17, 2016 at 2:39 PM, Craig Ringer <cr...@2ndquadrant.com> 
>> >> wrote:
>> >>> I wasted a bunch of time getting set up to test for such an ancient
>> >>> Perl and would love to save the next person along the hassle by
>> >>> documenting the easy way.
>> >>
>> >> It looks sensible to mention that in the README, so +1.
>
> I appreciate the labor. Anyway I don't object for adding that to
> the README. +1.

Thanks.

> I understand you :p By the way, the new doc points to
> http://install.perlbrew.pl and it just shows the install
> script. It seems more puzzling..
>
> I suppose https://perlbrew.pl/ seems to me the primary site for
> perbrew.

Oops!

Fixed in attached.

-- 
 Craig Ringer                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services
From e9a654aebd76abeadd5bc592191f8b01bce3716e Mon Sep 17 00:00:00 2001
From: Craig Ringer <cr...@2ndquadrant.com>
Date: Tue, 15 Nov 2016 15:45:41 +0800
Subject: [PATCH] Document that perl 5.8.0 is required

---
 src/test/perl/README | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/src/test/perl/README b/src/test/perl/README
index cfb45a1..0732cac 100644
--- a/src/test/perl/README
+++ b/src/test/perl/README
@@ -64,3 +64,21 @@ For available PostgreSQL-specific test methods and some example tests read the
 perldoc for the test modules, e.g.:
 
     perldoc src/test/perl/PostgresNode.pm
+
+Required Perl
+-------------
+
+Tests must run on perl 5.8.0 and newer. perlbrew is a good way to obtain
+such a Perl; see http://perlbrew.pl .
+
+Just install and
+
+    perlbrew --force install 5.8.0
+    perlbrew use 5.8.0
+    perlbrew install-cpanm
+    cpanm install IPC::Run
+
+then re-run configure to ensure the correct Perl is used when running tests. To verify
+that the right Perl was found:
+
+    grep ^PERL= config.log
-- 
2.5.5

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Reply via email to