On 11/14/16 3:52 AM, Michael Paquier wrote: > I don't mind. This patch uses the following pattern: > $(or $(PROVE_TESTS),t/*.pl) > While something more spread in Postgres source would be something like that: > $(if $(PROVE_TESTS),$(PROVE_TESTS),t/*.pl) > It seems to me that we'd prefer that for consistency, but I see no > reason to not keep your patch as well. I am marking that as ready for > committer.
($or ...) is a newer feature of GNU make, so we have avoided that so far. I have committed your v2 with $(if ...). -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
