Review of v7 0003-Add-PUBLICATION-catalogs-and-DDL.patch: This appears to address previous reviews and is looking pretty solid. I have some comments that are easily addressed:
[still from previous review] The code for OCLASS_PUBLICATION_REL in getObjectIdentityParts() does not fill in objname and objargs, as it is supposed to. catalog.sgml: pg_publication_rel column names must be updated after renaming alter_publication.sgml and elsewhere: typos PuBLISH_INSERT etc. create_publication.sgml: FOR TABLE ALL IN SCHEMA does not exist anymore create_publication.sgml: talks about not-yet-existing SUBSCRIPTION role DropPublicationById maybe name RemovePublicationById for consistency system_views.sql: C.relkind = 'r' unnecessary CheckCmdReplicaIdentity: error message says "cannot update", should distinguish between update and delete relcache.c: pubactions->pubinsert |= pubform->pubinsert; etc. should be ||= RelationData.rd_pubactions could be a bitmap, simplifying some memcpy and context management. But RelationData appears to favor rich data structures, so maybe that is fine. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
