Robert Haas <robertmh...@gmail.com> writes:
> On Fri, Sep 30, 2016 at 10:24 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
>> The problem seems to be that HeapTupleSatisfiesVacuum asserts
>> Assert(ItemPointerIsValid(&htup->t_self));
>> while collect_corrupt_items hasn't bothered to set up the t_self
>> field of the HeapTupleData it's passing in. This would imply that
>> you never tested this code in an assert-enabled build, which I find
>> surprising. Am I missing something?
> My standard build script uses --enable-cassert, so I doubt that's the
> case. It's more likely that on my system it just happened to find
> some non-zero garbage at that point on the stack that made it not fail
> the assertion.
Yeah, after I looked closer at what the Assert is actually testing,
I realized it was just blind luck that I'd managed to see it fail.
It's a pretty weak test :-(. Anyway, fixed now.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
