On Fri, Sep 23, 2016 at 6:11 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/23/16 1:56 AM, Amit Kapila wrote: >> which comment are you referring here? hashm_mapp contains block >> numbers of bitmap pages. > > The comment I'm referring to says > > The blknos of these bitmap pages are kept in bitmaps[]; nmaps is the > number of currently existing bitmaps. > > But there is no "bitmaps" field anywhere. >
Okay. You are right, it should be hashm_mapp. >> In the above code, it appears that you are trying to calculate >> max_avail space for all pages in same way. Don't you need to >> calculate it differently for bitmap page or meta page as they don't >> share the same format as other type of pages? > > Is this even useful for hash indexes? > I think so. It will be helpful for bucket and overflow pages. They store the index tuples similar to btree. Is there a reason, why you think it won't be useful? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
