On 2016/09/13 2:01, Corey Huinker wrote: > Thanks for the review! > > I agree with all the code cleanups suggested and have made then in the > attached patch, to save the committer some time.
Thanks. Have already marked the patch as ready for the committer. > Also in this patch, I changed sgml para to > <para> > Changing table-level options requires superuser privileges, for security > reasons: only a superuser should be able to determine which file is read > or which program is run. In principle non-superusers could be allowed to > change the other options, but that's not supported at present. > </para> > > "Determine" is an odd word in this context. I understand it to mean > "set/change", but I can see where a less familiar reader would take the > meaning to be "has permission to see the value already set". Either way, > it now mentions program as an option in addition to filename. Agreed. Thanks, Amit -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
