On Mon, Aug 8, 2016 at 5:11 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Aug 8, 2016 at 4:58 PM, Dilip Kumar <dilipbal...@gmail.com> wrote: >> >> On Wed, Aug 3, 2016 at 5:35 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> >>> I think that's just making life difficult. If nothing else, sqlsmith >>> hunts around for functions it can call that return internal errors, >>> and if we refuse to fix all of them to return user-facing errors, then >>> it's just crap for the people running sqlsmith to sift through and >>> it's a judgment call whether to fix each particular case. Even aside >>> from that, I think it's much better to have a clear and unambiguous >>> rule that elog is only for can't-happen things, not >>> we-don't-recommend-it things. >> >> >> I have changed for all these function to report more appropriate error with >> ereport. >> >> I used ERRCODE_WRONG_OBJECT_TYPE error code for reporting such errors. >> I think this is closest error code among all existing error codes, other >> options can be (ERRCODE_WRONG_OBJECT_TYPE). >> > > Your other options and the option you choose are same. >
Did you consider to use ERRCODE_UNDEFINED_COLUMN with error messages like: "type %u does not exit" or "type id %u does not exit"? Errorcode ERRCODE_UNDEFINED_COLUMN seems to be used for syscache lookup failure cases at certain places in code. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
