On Mon, Jul 4, 2016 at 4:29 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Jul 4, 2016 at 4:02 PM, Kyotaro HORIGUCHI > <horiguchi.kyot...@lab.ntt.co.jp> wrote: >> Hello, this is just an entry mail for the next CF. >> >> The tap-test fails when the soruce directoy containing spaces. I >> accidentially hit this by a Jenkins project with the name "test >> project". >> >> The function system_log() is safe for such parameters but >> backup() uses it in wrong way. On the other hand, >> enable_restoring() and enable_archiving() forgets to quote such a >> path containing spaces as already done for Windows. I don't see >> the similar problem in other places. > > Good catch, your fix looks good to me. I am noticing as well that the > invocations of pg_ctl, pg_dumpall, pg_upgrade and diff are likely > broken the same way in vcregress.pl.
And as is the command built for zic.exe in Install.pm, no? $target is normally an absolute path per the call of Install(). -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
